Widen API to allow storing keychain entries for an authenticated user #41
Conversation
load as an authenticated user; loadPassphrase is sufficient
WalkthroughThe recent update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
src/main/java/org/cryptomator/integrations/keychain/KeychainAccessProvider.java (1)
61-75: Ensure consistency in method documentation.The documentation for
storePassphraseForAuthenticatedUsershould be consistent with the documentation forstorePassphrase. Ensure that all relevant details are included and the format is consistent.- * @param key Key used to retrieve the passphrase via {@link #loadPassphrase(String)}. + * @param key Key used to retrieve the passphrase via {@link #loadPassphrase(String)}. - * @param displayName The according name to the key. That's the name of the vault displayed in the UI. + * @param displayName The name associated with the key, displayed in the UI. - * It's passed to the keychain as an additional information about the vault besides the key. + * It's passed to the keychain as additional information about the vault besides the key. - * The parameter does not need to be unique or be checked by the keychain. + * This parameter does not need to be unique or be checked by the keychain. - * @param passphrase The secret to store in this keychain. + * @param passphrase The secret to be stored in this keychain. - * @throws KeychainAccessException If storing the password failed + * @throws KeychainAccessException If storing the passphrase fails
src/main/java/org/cryptomator/integrations/keychain/KeychainAccessProvider.java
Outdated
Show resolved
Hide resolved
…cessProvider.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ychainAccessProvider.java" This reverts commit 81fb230.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/main/java/org/cryptomator/integrations/keychain/KeychainAccessProvider.java (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/main/java/org/cryptomator/integrations/keychain/KeychainAccessProvider.java
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/main/java/org/cryptomator/integrations/keychain/KeychainAccessProvider.java (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/main/java/org/cryptomator/integrations/keychain/KeychainAccessProvider.java
Belongs to cryptomator/cryptomator#3311