-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project to JDK 21 and JEP 442 #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infeo
requested review from
overheadhunter
and removed request for
overheadhunter
August 15, 2023 14:51
@overheadhunter Can you migrate the macOS project? It's should be nearly the same as for windows or the linux projects. |
overheadhunter
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, I only looked at the Linux aarch64 files. All my comments so far refer to all platforms.
jfuse-linux-aarch64/src/main/java/org/cryptomator/jfuse/linux/aarch64/FuseImpl.java
Outdated
Show resolved
Hide resolved
...linux-aarch64/src/main/java/org/cryptomator/jfuse/linux/aarch64/extr/fuse3/constants$37.java
Show resolved
Hide resolved
jfuse-linux-aarch64/src/main/java/org/cryptomator/jfuse/linux/aarch64/FuseArgs.java
Outdated
Show resolved
Hide resolved
[ci skip]
overheadhunter
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: JEP 442
Notable changes are, that the lifetime of an object is now managed via the Arena, not the MemoryScope anymore. Also, jextract now creates reproducible builds, but every extraction needs its own package or otherwise previously extracted classes are overwritten.