Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Crystal::NilableType to NilableReferenceType #14700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename Crystal::NilableType to NilableReferenceType #14700

wants to merge 1 commit into from

Conversation

HertzDevil
Copy link
Contributor

The name NilableType suggests that other types like NilableReferenceUnionType and NilableProcType inherit from it, but this is not the case.

@straight-shoota
Copy link
Member

The name is still not ideal because NilableReferenceUnionType and NilableReferenceType are pretty similar. Both inherit from UnionType which doesn't help making sense of the only difference in the names.

Perhaps we can find an even better naming solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:refactor topic:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HertzDevil @straight-shoota