Enable specs for close_on_exec on Windows
#14716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I would wait a bit for #14717 to decide if we change the default (IMO: we should) and do it in one go. |
|
I'd actually prefer to merge this first, and then the PR for #14717 on top. That way the effective change in behaviour will be explicitly documented in the spec changes. Also there's really no reason to postpone this addition. It's merely enabling specs for current behaviour. And as such is a different concern than changing behaviour. |
ysbaddaden
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These specs be enabled on Windows as well to ensure the expected behaviour (even though there's no mechanism for changing the value).