Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the static LLVM libraries on Windows CI #15074

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Drop the static LLVM libraries on Windows CI #15074

wants to merge 4 commits into from

Conversation

HertzDevil
Copy link
Contributor

These are no longer needed, because LLVM-C.dll is completely sufficient, and because nothing gets copied to the release packages.

@HertzDevil HertzDevil added platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci kind:chore labels Oct 10, 2024
@HertzDevil
Copy link
Contributor Author

It looks like Makefile.win still needs llvm-config.exe to determine the LLVM version and the host triple?

@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 10, 2024
@HertzDevil HertzDevil marked this pull request as draft October 10, 2024 15:26
@HertzDevil HertzDevil mentioned this pull request Oct 17, 2024
Draft
@straight-shoota straight-shoota removed this from the 1.15.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:chore platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota