Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Colorize::Object#print #15113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Colorize::Object#print #15113

wants to merge 4 commits into from

Conversation

devnote-dev
Copy link
Contributor

@devnote-dev devnote-dev commented Oct 21, 2024 •
edited
Loading

Closes #15079. I am cautious of the spec test for .bright.print as it returned different results when testing. (resolved now)

@devnote-dev
Copy link
Contributor Author

Reading the current CI failures are pointing to .dim.print being "\e[2m" not "\e[0;2m", however on my local machine this escape code is correct. 🤔

@devnote-dev
Copy link
Contributor Author

Seems to have been an environment issue, suddenly it's working fine again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Colorize::Object#print
3 participants
@devnote-dev @straight-shoota @Blacksmoke16