OpenBSD: fix integration and broken specs #15118
Conversation
ysbaddaden
added
kind:bug
| if program.has_flag?("freebsd") || program.has_flag?("openbsd") | ||
| # pkgs are installed to usr/local/lib but it's not in LIBRARY_PATH by | ||
| # default; we declare it to ease linking on these platforms: | ||
| link_flags += " -L/usr/local/lib" | ||
| end |
There was a problem hiding this comment.
thought: I was wondering about the motivation for this. Seems like the default configuration is just sub-optimal. Apparently compilers in ports do add the folder, only the system compiler does not (https://wiki.freebsd.org/WarnerLosh/UsrLocal).
Maybe we should add some reference for justification here? Not sure if that link would do, it was just the first relevant result on Google.
There was a problem hiding this comment.
If you build from ports, then a port can patch it in, yeah, but when you compile or cross compile your own crystal binary then it breaks and you must think to export LIBRARY_PATH.
It ain't much, but that's nice. We did it before, but that got lost and I couldn't find why.
| expect_raises(Socket::Addrinfo::Error, "Hostname lookup for badhostname failed: ") do | ||
| Socket::Addrinfo.resolve("badhostname", 80, type: Socket::Type::DGRAM) | ||
| expect_raises(Socket::Addrinfo::Error, "Hostname lookup for badhostname.unknown failed: ") do | ||
| Socket::Addrinfo.resolve("badhostname.unknown", 80, type: Socket::Type::DGRAM) |
There was a problem hiding this comment.
Oh, I didn't mean to push this fix in this PR but to make it it's own PR.
The problem here is that within my vagrant/libvirt VM resolving a hostname without an extension leads to 30 seconds (freeds, netbsd) to 2.5 minutes (openbsd) time to fail to resolve the name 😲
Using a domain with an extension, however, fails to resolve immediately 🤷
OpenBSD 7.4+ enforces Indirect Branch Tracking but we're not yet compatible in Crystal, so we disable the feature for the time being.
This results in always reporting: ``` bin/crystal[204]: Brewfile: not found ```
ysbaddaden
force-pushed
the
fix/openbsd-integration
branch
from
d8c7592
to
848f61f
Compare
Fixes compatibility with OpenBSD 7.4 that enforced indirect branch tracking by default but we're not compatible yet (see crystal-lang#13665), so we must disable it. With this patch I can run the std specs, except for the SSL specs because of openssl/libressl mess, as well as the compiler specs, except for the interpreter specs that regularly crash with SIGABRT (may help to debug issues in the interpreter). Note: the segfault handler is broken on OpenBSD and processes eventually crash with SIGILL after receiving SIGSEGV.
Follow up of #15115 but for OpenBSD.
Fixes compatibility with OpenBSD 7.4 that enforced indirect branch tracking by default but we're not compatible yet (see #13665), so we must disable it.
With this patch I can run the std specs, except for the SSL specs because of openssl/libressl mess, as well as the compiler specs, except for the interpreter specs that regularly crash with SIGABRT (may help to debug issues in the interpreter).
Note: the segfault handler is broken on OpenBSD and processes eventually crash with SIGILL after receiving SIGSEGV.