Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip .1 minor version from find-llvm-config #15143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

straight-shoota
Copy link
Member

In its help message, the find message only strips .0 minor from the version string. Recent LLVM versions use the .1 minor version to indicate a stable release, so we have 18.1 and 19.1 in the file.

Error output before and after this patch:

 Error: Could not find location of llvm-config. Please specify path in environment variable LLVM_CONFIG.
-Supported LLVM versions: 19.1 18.1 17 16 15 14 13 12 11.1 11 10 9 8
+Supported LLVM versions: 19 18 17 16 15 14 13 12 11 11 10 9 8

@straight-shoota
Copy link
Member Author

Argh, looks like 11.1 is an edge case. Maybe we should hard code that as an exception 🤔
Alternatively, we could drop the stripping entirely and just print the versions fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant