Implement pre-defining structs/unions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a struct or a union is already defined in a lib with the same name as the transformer would generated, use that defined structure instead of generating a new one. One particular usecase for this is defining structures that use bitfields manually and then using those instead of the incorrectly generated by crystal_lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a struct or a union is already defined in a lib with the same
name as the transformer would generate, use that defined structure
instead of generating a new one. One particular usecase for this is
defining structures that use bitfields manually and then using those
instead of the incorrectly generated by crystal_lib.
This is somewhat related to #70, but even without that generating the same struct
if one is already defined makes the file not compile, so using the one already defined
seems like the proper behaviour.