Forward unmodified ARGV to subcommand #631
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR aims to forward all arguments supplied to
shards
to the subcommand, if found.It does this to allow correct parsing of all ARGV supplied, including
SHARDS_OPTS
that might be appended, avoids altering the originalARGV
when combining it.Introduces a naive integration test for subcommand to validate the change works correctly.
Last but not least, allows also forwarding
--help
by avoiding it to short-circuit and return immediately bysetting a flag for it and evaluating at the end of the processing of unknown options.
This is only done for the CLI invocation and is not part of Shards module (as the help and usage options are only available in this context).
I'm not sure about the implementation as this was the first integration test for subcommands, so would appreciate some notes on additional changes.
Thank you.
Fixes #600