use latest versions #45
Conversation
|
WalkthroughThe changes primarily focus on updating the installation process for various tools in the Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- packer/provision.sh (2)
Review comments generated (3)
- Review: 3
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
packer/provision.sh
Outdated
| curl -fsSL https://github.com/crytic/medusa/releases/download/v0.1.3/medusa-linux-x64.tar.gz -o /tmp/medusa.tar.gz | ||
| echo "Extracting medusa..." | ||
| tar -xzf /tmp/medusa.tar.gz -C /tmp | ||
| echo "Installing medusa..." | ||
| chmod +x medusa | ||
| sudo mv medusa /usr/local/bin |
There was a problem hiding this comment.
Similar to the previous comment, the downloaded file /tmp/medusa.tar.gz is not being removed after extraction and installation. Also, the chmod +x medusa command seems to be executed in the wrong directory. It should be executed in the /tmp directory where the file was extracted.
tar -xzf /tmp/medusa.tar.gz -C /tmp
echo "Installing medusa..."
- chmod +x medusa
+ chmod +x /tmp/medusa
sudo mv /tmp/medusa /usr/local/bin
+ rm /tmp/medusa.tar.gz
There was a problem hiding this comment.
the rm is here already as well 👀
There was a problem hiding this comment.
@elopez You're correct, my apologies for the oversight. The rm /tmp/medusa.tar.gz command is indeed present in the script to remove the downloaded tar file after extraction and installation. However, the correction for the chmod +x medusa command still stands. It should be executed in the /tmp directory where the file was extracted. Here's the corrected line:
- chmod +x medusa
+ chmod +x /tmp/medusaThank you for pointing out the mistake.
packer/provision.sh
Outdated
| curl -fsSL https://github.com/crytic/medusa/releases/download/v0.1.3/medusa-linux-x64.tar.gz -o /tmp/medusa.tar.gz | ||
| echo "Extracting medusa..." | ||
| tar -xzf /tmp/medusa.tar.gz -C /tmp | ||
| echo "Installing medusa..." | ||
| chmod +x medusa | ||
| sudo mv medusa /usr/local/bin |
There was a problem hiding this comment.
the rm is here already as well 👀
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
There was a problem hiding this comment.
Files selected (1)
- packer/provision.sh (1)
Review comments generated (3)
- Review: 2
- LGTM: 1
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- packer/provision.sh (2)
Files skipped from review due to trivial changes (1)
- packer/provision.sh
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
LGTM, thanks for taking care of this.
Creation of packer images has been failing recently. Not related to this PR, but just a heads up: deployment of an image with latest echidna/medusa/solc to regions other than nyc3 might be delayed. cc @oldsj
Summary by CodeRabbit
provision.shfor various tools including solc, slither, echidna, and medusa. The changes ensure that the latest versions of these tools are fetched and installed.apt-get updateandapt-get install -y unzipcommands to streamline the setup process.These changes aim to keep the system setup and dependencies up-to-date, enhancing the reliability and performance of the environment.