docker: make container multi-platform #1136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would allow us to then include the aarch64 binary in eth-security-toolbox. |
This way we get musl static binaries
elopez
force-pushed
the
docker-multiplatform
branch
from
0935928
to
b6ed0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables aarch64 builds for our Docker container image. These can then be used on e.g. M1 Macs to get good performance. It also makes the echidna binary static with musl -- previously it was static with glibc, which might be problematic as shown on #962 if the binary is re-used outside this container (I believe using it inside the container should not cause issues as the glibc version matches between binary and runtime environment)
Caveat: The container is built on an x86 runner using emulation, so the build is somewhat slow (~4h total build time).