Raise default number of workers #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
reviewed
Jul 15, 2024
| getNFuzzWorkers conf = fromIntegral (fromMaybe 1 (conf.workers)) | ||
| getNFuzzWorkers conf = maybe defaultN fromIntegral conf.workers | ||
| where | ||
| n = numCapabilities |
There was a problem hiding this comment.
is it the same as getNumCapabilities?
There was a problem hiding this comment.
yes, but this is "pure", getNumCapabilities is IO
lib/Echidna/Types/Campaign.hs
Outdated
| where | ||
| n = numCapabilities | ||
| maxN = max 1 (n - 1) -- one dedicated thread for shrinking | ||
| defaultN = min 3 maxN -- capped at 3 by default |
There was a problem hiding this comment.
@ggrieco-tob suggested the value
There was a problem hiding this comment.
it's a reasonable number for default, we can increase if we want later.
There was a problem hiding this comment.
I switched it to 4, considering I dropped the -1
|
Does this close #1252 |
Now the default number of workers will be equal to the number of cores on the system, with a minimum of 1 and a maximum of 4.
elopez
force-pushed
the
dev-workers-default
branch
from
d514836
to
28575e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the default number of workers will be equal to the number of cores on the system, with a minimum of 1 and a maximum of 4.