volumegroup: add parameters to modifyvolumegroup #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rakshith-R
approved these changes
Jul 30, 2024
nixpanic
reviewed
Jul 30, 2024
volumegroup/README.md
Outdated
| @@ -205,6 +205,10 @@ message ModifyVolumeGroupMembershipRequest { | |||
| // This field is OPTIONAL. Refer to the `Secrets Requirements` | |||
| // section on how to use this field. | |||
| map<string, string> secrets = 3 [(csi.v1.csi_secret) = true]; | |||
|
|
|||
| // parameters passed to the plugin to modify the volume group. | |||
There was a problem hiding this comment.
The commit message mentions that the parameters can be used to modify the volumes in the group. Here the parameters are for the group itself. Which one is it, or both? Consider adding a little description for it above the protobuf message in the parargaph.
There was a problem hiding this comment.
update the commit and comment to match the same, it's up to the plugin what it wants to do with it as its opaque parameters from the spec point.
adding optional parameters to pass to the ModifyVolumeGroupMembershipRequest so that plugin can use the parameters to modify the volume group or to modify the volumes in the group. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1
force-pushed
the
add-param-modifyvolumegroup
branch
from
20287cb
to
79cbb9d
Compare
nixpanic
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding optional parameters to pass to the ModifyVolumeGroupMembershipRequest so that the plugin can use the parameters to for the volumes in the group. For example we need to know the flatten Mode when adding the new images