-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool to produce a time calibration HDF5 file #600
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 72 72
Lines 5541 5541
=======================================
Hits 4705 4705
Misses 836 836 ☔ View full report in Codecov by Sentry. |
2493d35
to
9071abe
Compare
I guess that for testing this PR we need bigger raw files than those already present in
|
@Bultako is that an option? Could you run the test with less required events? And maybe fix the language of the error? |
For the time calibration it is complicated because you need to cover all capacitors to be able to calculate the time correction for all of them. In principle the exception is right and you should not be able to produce a time calibration file without covering all capacitors. |
We can also try to look for the smallest possible file. Unfortunately that will be around 1000 events or so I think. |
5057216
to
9487a07
Compare
9a04e4c
to
581bb66
Compare
4a1ce25
to
e5fbc15
Compare
this one was reviewed and approved, could you re-approve @maxnoe so we can also include it in the next release? |
I think we need to adapt the onsite scripts so that actually the new tool is called, right? |
I would get this tool in the release before, and then lstosa can be later updated to use it |
I am not talking about osa, I am talking about the onsite scripts in this repo. |
I think we should concentrate towards what is blocking release 0.8.0 |
ok, let's leave this for lstchain > v0.8 |
Should be closed? |
Yes, all the calibration related tools have been moved to the new lstcam-calib project, we shouldn't update the ones here |
This PR is the continuation of #533 developed in a forked repo and now with the code placed in a branch of
lstchain
repo.It adds a new Tool
lstchain_create_time_calibration_file