-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop camera frame #2396
base: main
Are you sure you want to change the base?
Drop camera frame #2396
Conversation
2b038da
to
4eafc36
Compare
still one issue in tutorials/ctapipe_handson.py, seems like I'm zooming into the wrong region because of the transformation to |
New traitlets version seems to come with more broken sphinx stuff in their docs, need to add to the ignore rules |
Great! This reminds me I should look back at #2279 as well once this is finished. |
I added the traitlets docs fixes and the changelog |
434e097
to
b4b0af3
Compare
b4b0af3
to
7425f97
Compare
Fixed a notebook |
We discussed today in the meeting that this is as much a breaking change or more than the container restructuring discussed in CEP-2, so we decided that we will also write a CEP for this change. Technically, this looks already fine and is ready to merge. Edit: CEP PR here: #2405 |
7425f97
to
44a04c9
Compare
@StFroese could you update this fixing the conflict and getting the fixed codecov in? |
44a04c9
to
07a6c41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
===========================================
- Coverage 92.52% 60.60% -31.93%
===========================================
Files 235 3 -232
Lines 20024 33 -19991
===========================================
- Hits 18528 20 -18508
+ Misses 1496 13 -1483 ☔ View full report in Codecov by Sentry. |
07a6c41
to
193cfb8
Compare
193cfb8
to
ff70dce
Compare
Co-Authored-By: Stefan Fröse <stefan.froese@udo.edu> Co-Authored-By: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
ff70dce
to
0391b4c
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Analysis Details0 IssuesCoverage and DuplicationsProject ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
As you may remember, I already started this here #2141. A lot happened since the last time (i.e. moving the muon processing), so I decided to give this another try on a fresh branch to avoid rebasing