Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatfielding factor instead of absolute & relative factor for amplitude correction #2433

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StFroese
Copy link
Member

closes #1397

@StFroese StFroese requested review from maxnoe and removed request for watsonjj October 27, 2023 12:40
ctapipe/containers.py Outdated Show resolved Hide resolved
@maxnoe maxnoe marked this pull request as draft November 17, 2023 11:40
@Hckjs
Copy link
Contributor

Hckjs commented Aug 13, 2024

Was it on purpose to set this PR to draft again? @maxnoe

Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments to the linked issue, but I disagree that these should be separated. Flat-fielding and gain correction are not the same thing: even if you can combine them, you are losing important information that is needed for data quality monitoring as well as for better reconstruction techniques that do not use the flatfielding information but do use the absolute gains.

@maxnoe
Copy link
Member

maxnoe commented Sep 3, 2024

: even if you can combine them, you are losing important information that is needed for data quality monitoring as well as for better reconstruction techniques that do not use the flatfielding information but do use the absolute gains.

The change here and discussed in #1397 is not about the monitored quantities, it's about what is filled into the event so that it can be applied in the CameraCalibrator.

I argued that the event should only contain a single correction coefficient, that is computed from all the different monitoring inputs we have for that specific event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DL1 charge calibration in event to be a single, relative coefficient per channel / pixel
5 participants