Remove some obsolete TODOs

[kosack]

I left a few in where they seemed to be still unresolved, or where it wasn't clear (the latter was particularly in table_interpolator.py and unstructured_interpolator.py).

[maxnoe]

I think this one still applies (see #1777 )

[kosack]

Do we still want to support DSTs? if so, should that be written here as a TODO? I would expect it to be an issue, but nothing in the code.

[maxnoe]

@kosack the CI run fails because the job from your fork doesn't have access to SONAR_TOKEN.

Which is really not good and we should have noticed earlier... how to we proceed here? Convert the SONAR_TOKEN from a secret to a simple env variable? Doesn't seem like a good idea.

[kosack]

Which is really not good and we should have noticed earlier... how to we proceed here? Convert the SONAR_TOKEN from a secret to a simple env variable? Doesn't seem like a good idea.

I could also just push it to upstream and re-open the PR. But it is a general problem if people develop in their own forks. Not sure how that is usually dealt with? In larger open-source projects, I can't imagine everyone sets up sonar tokens for their own forks

[maxnoe]

See the issue I created: #2577 and an attempt at a fix I found in the sonarqube forums: #2578

[maxnoe]

You could leave this open here so we can test after merging #2578

[maxnoe]

sonarqube reporting should work again now, let's see

[ctao-dpps-sonarqube]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• No coverage information (94.20% Estimated after merge)
• 0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

[maxnoe]

FINALLY