Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for gain selection automation #293

Open
wants to merge 72 commits into
base: main
Choose a base branch
from

Conversation

marialainez
Copy link
Collaborator

@marialainez marialainez commented Jun 12, 2024

Main changes that have been made in this PR:

  • Write history files for each subrun (apart from the log files) + update them every time the gain selection script is launched
  • Allow launching the gain selection script several times without launching the jobs that are already running again (if the history file exists and is empty for a given subrun, it means that the job is running for that run, so it doesn't launch it again)
  • Change the check option so that it is done looking at the history files and not at the log files
  • Add simulate option to the gain selection script
  • Once the gain selection finishes correctly for all runs, the gain selection script is launched with the check option to see if there is any run missing that needs to be copied to R0G.

@marialainez marialainez marked this pull request as draft June 12, 2024 13:26
src/osa/job.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/datasequence.py Outdated Show resolved Hide resolved
src/osa/scripts/datasequence.py Outdated Show resolved Hide resolved
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes in the log messages, to make following the logs easier. I would just leave some log info messages for general actions happening and maybe just give info at run level.

src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/sequencer.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
src/osa/scripts/gain_selection.py Outdated Show resolved Hide resolved
@marialainez marialainez marked this pull request as ready for review August 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants