Bkg from off data #5
Conversation
- implementation largely follows the implementation of the Exclusion region method, except it requires off data - implementation of the corresponding prozessing class not fully finished.
TODO: - Testing the functionality of the class with data files.
| @@ -908,3 +909,40 @@ def bkg_map_maker(self, maker): | |||
| if not isinstance(maker, ExclusionMap): | |||
| raise TypeError(f"Maker must be of type {ExclusionMap}") | |||
| BkgMakerBase.bkg_map_maker.fset(maker) | |||
There was a problem hiding this comment.
I think this can be simplified to BkgMakerBase.bkg_map_maker = maker
| def __init__(self, off_runs, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.off_runs = off_runs | ||
| self.excl_region = [Regions.parse(reg,format='ds9') for reg in |
There was a problem hiding this comment.
Suggest removing the line break after in.
There was a problem hiding this comment.
I can introduce the line break earlier, but lines exceeding 100 characters are in disagreement with the python coding guidelines. Personally, I do not find this 100 character limit too important, so let me know what you think.
| self.off_files] | ||
| ) | ||
| ) | ||
| self.excl_region = [Regions.parse(reg,format='ds9') for reg in |
There was a problem hiding this comment.
Suggest removing the line break after in.
There was a problem hiding this comment.
Same as above, I can break the line at a different place. Too long line disagrees with coding guidelines. No strong personally opinion on it.
| return RectangularCameraImage(counts, self.xedges, self.yedges, self.energy_edges, exposure=exposure) | ||
|
|
||
| class OffDataMap: | ||
| """_summary_ |
There was a problem hiding this comment.
Here and below: suggest filling these placeholders before merging,
| RectangularCameraImage | ||
| _description_ | ||
| """ | ||
| neighbours = find_run_neighbours(target_run, self.off_runs, self.pointing_delta) |
There was a problem hiding this comment.
The non-optional time_delta argument is missing. The function signature is
def find_run_neighbours(target_run, run_list, time_delta, pointing_delta)I suppose some large value e.g. time_delta = numpy.inf * u.hr can be provided here, if I correctly understand the logic of the proposed OffDataMap class.
| @@ -123,27 +123,48 @@ def get_runwise_bkg(self, target_run)->RectangularCameraImage: | |||
| return RectangularCameraImage(counts, self.xedges, self.yedges, self.energy_edges, exposure=exposure) | |||
|
|
|||
| class ExclusionMap: | |||
There was a problem hiding this comment.
Inheritance from BaseMap (?) is missing.
No description provided.