Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draco: Pointclouds with NaNs are damaged by compression (Melodic) or fail (Noetic) #1

Closed
peci1 opened this issue Jun 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@peci1
Copy link
Member

peci1 commented Jun 16, 2023

According to google/draco#633 (comment), draco cannot compress invalid float values. Howerver, draco_point_cloud_transport doesn't filter non-dense clouds to remove the invalid points before passing the cloud to draco.

On melodic with its older draco version, this does result in silent damage done to the pointcloud

On noetic, this results in the following error:

Error encoding message by transport draco: Draco encoder returned code -1: Failed to encode point attributes...
@peci1
Copy link
Member Author

peci1 commented Jun 16, 2023

Fixed in 4642f9a .

@peci1 peci1 closed this as completed Jun 16, 2023
@peci1 peci1 self-assigned this Jun 16, 2023
@peci1 peci1 added the bug Something isn't working label Jun 16, 2023
@peci1 peci1 pinned this issue Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant