Skip to content

Commit

Permalink
[FIXUP] proper override for dropTable
Browse files Browse the repository at this point in the history
  • Loading branch information
mcheshkov committed Nov 18, 2024
1 parent 02d41bb commit cc472af
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,10 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface {
return this.query('SELECT name as table_name FROM system.tables WHERE database = ?', [schemaName]);
}

public override async dropTable(tableName: string, _options?: QueryOptions): Promise<void> {

Check failure on line 576 in packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts

View workflow job for this annotation

GitHub Actions / unit (20.x)

Cannot find name 'QueryOptions'.

Check failure on line 576 in packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts

View workflow job for this annotation

GitHub Actions / unit (22.x)

Cannot find name 'QueryOptions'.

Check failure on line 576 in packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts

View workflow job for this annotation

GitHub Actions / integration-smoke (20.x)

Cannot find name 'QueryOptions'.

Check failure on line 576 in packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts

View workflow job for this annotation

GitHub Actions / integration-cubestore (20.x)

Cannot find name 'QueryOptions'.
await this.command(`DROP TABLE ${tableName}`);
}

protected getExportBucket(
dataSource: string,
): ClickhouseDriverExportAWS | undefined {
Expand Down

0 comments on commit cc472af

Please sign in to comment.