Merge pull request #652 from cucumber/issue-614-no-binmode

Do not set binmode on output temp files
cucumber · Jun 30, 2019 · fb1fdd3 · fb1fdd3
2 parents 3109b9e + cc3a818
commit fb1fdd3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/aruba/processes/spawn_process.rb b/lib/aruba/processes/spawn_process.rb
@@ -79,8 +79,10 @@ def start
         @stdout_file.sync = true
         @stderr_file.sync = true
 
-        @stdout_file.binmode
-        @stderr_file.binmode
+        if RUBY_VERSION >= '1.9'
+          @stdout_file.set_encoding('ASCII-8BIT')
+          @stderr_file.set_encoding('ASCII-8BIT')
+        end
 
         @exit_status = nil
         @duplex      = true