Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Rebased] Improve AppVeyor build #567

Closed
wants to merge 24 commits into from

Commits on May 14, 2018

  1. Test on appveyor only with Ruby 2.0 and up

    - The fat binaries for the ffi gem do not support Ruby 1.9.3, hence
      testing on this version on Windows makes no sense.
    - To set Ruby version 2.0.0, the micro version also needs to be set.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    19fe24c View commit details
    Browse the repository at this point in the history
  2. Wrap long lines

    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    45f9f46 View commit details
    Browse the repository at this point in the history
  3. Remove trailing blank space

    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    113d5cf View commit details
    Browse the repository at this point in the history
  4. Make command_runtime_environment blank by default

    The existing default is not needed, since ENV is always used as a base
    for the local environment.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    eb645e4 View commit details
    Browse the repository at this point in the history
  5. Clean up environment variable handling

    - Use inject on all versions of Ruby, not need to make a distinction
      here.
    - Clean up overrides in WindowsEnvironmentVariables
    - Override to_h in WindowsEnvironmentVariables so it correctly upcases
      ENV values.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f5a8fba View commit details
    Browse the repository at this point in the history
  6. Remove parameters with defaults

    SpawnProcess should work without specifying these, and there are no
    specs that essentially override these defaults.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    6b51f06 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e871767 View commit details
    Browse the repository at this point in the history
  8. Simplify specs for stderr handling

    Instead of setting up or using a shell script, just use Ruby with a
    script on the command line.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    5073f66 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1f24406 View commit details
    Browse the repository at this point in the history
  10. Clean up spec for ChildProcess launch error

    This splits the specs in a Unix and Windows versions, just like for the
    specs for commands with spaces.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    330fb90 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    85f4b99 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c77da7b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a295dd6 View commit details
    Browse the repository at this point in the history
  14. Remove #to_s from CommandString classes

    This method basically returns one of the initializer arguments so makes
    little sense.
    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ea5c3b6 View commit details
    Browse the repository at this point in the history
  15. Replace match? to support older Rubies

    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    95dc752 View commit details
    Browse the repository at this point in the history
  16. Allow any line ending

    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    7ca2e64 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6d01a37 View commit details
    Browse the repository at this point in the history
  18. Skip permission scenarios on Windows

    mvz authored and xtrasimplicity committed May 14, 2018
    Configuration menu
    Copy the full SHA
    9f899bf View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    8b441b9 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. Configuration menu
    Copy the full SHA
    9f97f96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2210189 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdad6ea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dcd0015 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5859fb3 View commit details
    Browse the repository at this point in the history