Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows internal commands #655

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jul 3, 2019

Summary

Support windows internal commands by accepting them as existing commands.

Details

Allow SpawnProcess to find built-in shell commands in addition to real executable files. Provide list of such built-in commands for Windows.

Motivation and Context

How Has This Been Tested?

TBA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz
Copy link
Contributor Author

mvz commented Jul 3, 2019

@xtrasimplicity I extracted some of your work on #505 to this pull request. For some reason, specs are all green on Appveyor without these changes, which tells me that it somehow exposes some unix utilities. Any idea how to disable that?

@mvz mvz merged commit 9b6b4b2 into master Jul 3, 2019
@mvz mvz deleted the support-windows-internal-commands branch July 3, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Aruba doesn't know how to run "built-in" DOS commands
2 participants