Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully test on Windows #894

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Fully test on Windows #894

wants to merge 35 commits into from

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 22, 2023

Summary

Run Cucumber suite on Windows as well and make it pass

Details

This is a reprise of #505, #619, #799, and #817. I'm opening a new pull request to be able to base it on #892 and make the minimal changes needed.

Motivation and Context

If we want to say Aruba supports Windows, we should at least have the full test suite run on Windows in CI.

How Has This Been Tested?

CI will tell us where we stand

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mscottford mscottford mentioned this pull request Jul 7, 2023
Open
8 tasks
@mvz mvz force-pushed the fully-test-on-windows branch 2 times, most recently from b9626b5 to 78b85dc Compare December 25, 2023 15:02
@mvz mvz force-pushed the fully-test-on-windows branch 5 times, most recently from d0858f2 to 1460be7 Compare November 15, 2024 07:49
@mvz mvz mentioned this pull request Nov 15, 2024
Merged
mvz and others added 20 commits November 15, 2024 14:58
@mvz
Run cucumber scenarios on Windows
abc3c2b
@mvz
TMP: limit set of platforms
3096eea
@mvz
Add bat runner for default test cli app
47764d2
@xtrasimplicity @mvz
CI: Skip scenarios with @requires-bash unless bash is installed.
6ad4dd6
@xtrasimplicity @mvz
CI: Windows - Fixed 01\getting_started\RunCommands feature.
44a2b6f
@xtrasimplicity @mvz
CI: Windows - Fixed supported_testing_frameworks.feature
7d658f3
@mvz
TMP: Split cucumber scenarios by section
2498edb
@mvz
Use default executable instead of specifying another
eb800ee
@mvz
Provide separate scenarios for Windows and Unix for be_a_command_foun…
58b5d6a 
…d_in_path
@mvz
Make check_timeouts feature cross-platform
c5733d5 
* Use existing commands instead of non-portable bash scripts
* Use timeout command if sleep is not available
@xtrasimplicity @mvz
Started adding unpublished windows-specific features.
780646d
@xtrasimplicity @mvz
CI: Windows - Fixed CleanUpWorkingDirectory feature.
c64b2f2
@xtrasimplicity @mvz
Fixed usage of .cucumberproignore file.
2d2173b
@xtrasimplicity @mvz
Add @requires-sleep hook
9c27183
@xtrasimplicity @mvz
CI: Windows - Fixed 02_ConfiguringAruba\CommandRuntimeEnvironment.fea…
11be37e 
…ture
@xtrasimplicity @mvz
CI: Windows - Skip Exit timeout config. Added ToDo.
bf95659
@xtrasimplicity @mvz
CI: Windows - Fixed 02_Configuring_Aruba\HomeDirectory feature.
ba39dcc
@xtrasimplicity @mvz
CI: Windows - Fixed 03\testing_frameworks\cucumber\announce_...
67d3930
@xtrasimplicity @mvz
CI: Windows - Fixed disabling bundler feature.
e9619ad
@xtrasimplicity @mvz
CI: Windows - Fix define_after_hook_for_commands feature.
be045ed
xtrasimplicity and others added 10 commits November 15, 2024 14:58
@xtrasimplicity @mvz
CI: Windows - Fix define_before_hook_for_commands feature. (Cucumber)
0dd19be
@xtrasimplicity @mvz
CI: Windows - Fixed check_for_exit_status feature (Cucumber)
af372ab
@mvz
Mark Windows-only version of Cleanup Working Directory feature as such
4ee6268
@mvz
Windows: Fix getting started with aruba/run commands feature
9c918a6
@mvz
Windows: Unify announce_information_for_troubleshooting feature
c1158dd
@mvz
Windows: Unify check_for_exit_statuses feature
9195703
@mvz
Make check_output_of_command feature platform independent
55fc43d 
- Do not use bash scripts
- Directly run echo or ruby where possible
- Move large output edge case to spec
@mvz
Make 02_configure_aruba/basics feature platform-independent
b600a57
@mvz
Remove edge-case scenario
4b7286e
@mvz
Re-organize and improve output check scenarios
1525fdc 
- Move scenarios for checking success + output to a separate feature
- Unify order and implementation of scenarios for checking output,
  stderr and stdout
@mvz
Tighten output check in Cucumber step testing RSpec success
74971f1 
This change ensures no errors were reported, and that both checks are
performed before reporting any failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @xtrasimplicity