Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TMP: Re-run on windows with the same seed #925

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

TMP: Re-run on windows with the same seed #925

wants to merge 5 commits into from

Commits on Nov 10, 2024

  1. Re-run on windows with the same seed

    @mvz
    mvz committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    6a02752 View commit details
    Browse the repository at this point in the history

  2. Unlink Tempfiles after use in SpawnProcess 

    On Windows, the finalizer for Tempfile will raise an error if
Errno::ENOACCES is raised when removing the file. However, if this
happens when #unlink is called, the error is caught.

This change calls #unlink on the Tempfiles that are used to store the
output of spawned processes. This means the finalizer will not need to
unlink the file, so any Errno::ENOACCES errors during unlinking will be
caught.

The raised errors did not make any specs fail, but they did appear in
the rspec output.
    @mvz
    mvz committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    fa65b8d View commit details
    Browse the repository at this point in the history

  3. TMP: Print some details

    @mvz
    mvz committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    4f130f7 View commit details
    Browse the repository at this point in the history

  4. Validate that Aruba scratch directory is empty at setup time

    @mvz
    mvz committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    9228bfc View commit details
    Browse the repository at this point in the history

  5. WIP: Add hard check that temp files are unkinked

    @mvz
    mvz committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    e0ef408 View commit details
    Browse the repository at this point in the history