Move UnixPlatform#simple_table into Announcer #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #simple_table method is only used inside Announcer and is not platform-dependent. This changes moves that method to Announcer and makes it private. Specs for #simple_table are updated to test SimpleTable directly instead. The implementation of SimpleTable is adjusted to only take one option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
UnixPlatform#simple_tabletoAnnouncer.Details
The
#simple_tablemethod is only used insideAnnouncerand is not platform-dependent. This changes moves that method toAnnouncerand makes it private. Specs for#simple_tableare updated to testSimpleTabledirectly instead.The implementation of
SimpleTableis adjusted to only take one option.Motivation and Context
This refactoring was part of a larger branch but it's useful to merge this already.
How Has This Been Tested?
I ran the specs. CI will run the cukes.
Types of changes