New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set navbar a default value #735

Merged

yaolifeng0629 merged 1 commit into cuixueshe:main from Jayden12138:fix/navbar

Jul 12, 2024

Contributor

Jayden12138 commented Jul 8, 2024

set a href default value
add type to HEADER_OPTIONS

It's pointless!There is no default value set.

optItem.target ?? optItem.target

// https://developer.mozilla.org/zh-CN/docs/Web/HTML/Element/a#target
=> optItem.target ?? '_self'

optItem.target ?? '_self' is equivalent to optItem.target ? optItem.target : '_self'


          fix: set navbar a default value

9502ca4

yaolifeng0629 self-requested a review

July 9, 2024 01:46

yaolifeng0629 approved these changes

•

View reviewed changes

yaolifeng0629 merged commit 540739b into cuixueshe:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet