Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _WIN32 define instead of WIN32 #68

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Use _WIN32 define instead of WIN32 #68

merged 1 commit into from
Mar 12, 2024

Conversation

netadr
Copy link
Contributor

@netadr netadr commented Mar 11, 2024

_WIN32 is more reliable as it is defined by the compiler instead of Windows.h. Under two different build environments, I encountered an issue where WIN32 wasn't defined which resulted in a compiler error.

Copy link
Owner

@cursey cursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cursey cursey merged commit 629558c into cursey:main Mar 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants