-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section for experimental custom regex scopes to customization.md #2315
Conversation
Once this is merged, I'll update https://github.com/cursorless-dev/cursorless/wiki/Custom-regex-scopes to point to this new section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Left a bunch of minor suggestions / edits
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Based on feedback from PR
Fix link to implementation (link copied from GitHub was missing the repository name)
Try again fixing the link to `packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/RegexScopeHandler.ts` If this doesn't work, I'll just mention the filename probably
Trying to add relative path similar to `snippets.md` saw in file.
Changes made (some outstanding questions), ready for another review. Let me know if any tweaks are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I made a few changes to bring it home; feel free to have a look if you're curious!
Checklist