Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section for experimental custom regex scopes to customization.md #2315

Merged
merged 12 commits into from
May 1, 2024
Merged

Add section for experimental custom regex scopes to customization.md #2315

merged 12 commits into from
May 1, 2024

Conversation

CodesAway
Copy link
Contributor

Checklist

  • No functionality was changed, so no tests were written
  • Updated docs, but not cheatsheet (since it's only user settings change, not Cursorless change)
  • No changes to cheatsheet were made

@CodesAway
Copy link
Contributor Author

Once this is merged, I'll update https://github.com/cursorless-dev/cursorless/wiki/Custom-regex-scopes to point to this new section.

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Left a bunch of minor suggestions / edits

docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
pre-commit-ci-lite bot and others added 9 commits April 30, 2024 08:24
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Based on feedback from PR
Fix link to implementation (link copied from GitHub was missing the repository name)
Try again fixing the link to `packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/RegexScopeHandler.ts`

If this doesn't work, I'll just mention the filename probably
Trying to add relative path similar to `snippets.md` saw in file.
@CodesAway
Copy link
Contributor Author

Changes made (some outstanding questions), ready for another review. Let me know if any tweaks are needed.

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I made a few changes to bring it home; feel free to have a look if you're curious!

@pokey pokey added this pull request to the merge queue May 1, 2024
Merged via the queue into cursorless-dev:main with commit e0a9806 May 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants