Default value for preferred scope setting #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
approved these changes
Nov 20, 2024
cursorless-bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
I got unreliable behavior when we didn't have a default value here. Turns out that if you don't have a default value get will not actually return none. It will return a `NoValueType` object and that is evaluated to true in the if statements so everybody probably has preferred scope on now. This might be a change to Talon because I can't believe we didn't catch this earlier. ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got unreliable behavior when we didn't have a default value here. Turns out that if you don't have a default value
settings.get(id, default)will not actually return none or your specified default value. It will return aNoValueTypeobject and that is evaluated to true in the if statements so everybody probably has preferred scope on now. This might be a change to Talon because I can't believe we didn't catch this earlier.Checklist