check nonzero math impl

curvefi · Nov 23, 2023 · 7875cae · 7875cae
1 parent ac588b0
commit 7875cae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/contracts/main/CurveCryptoMathOptimized2.vy b/contracts/main/CurveCryptoMathOptimized2.vy
@@ -496,7 +496,6 @@ def get_p(
     denominator: uint256 = (GK0 + unsafe_div(unsafe_div(NNAG2 * _xp[0], _D) * K0, 10**36) )
 
     # p_xy = x * (GK0 + NNAG2 * y / D * K0 / 10**36) / y * 10**18 / denominator
-    # p_xz = x * (GK0 + NNAG2 * z / D * K0 / 10**36) / z * 10**18 / denominator
     # p is in 10**18 precision.
     return unsafe_div(
         _xp[0] * ( GK0 + unsafe_div(unsafe_div(NNAG2 * _xp[1], _D) * K0, 10**36) ) / _xp[1] * 10**18,

diff --git a/contracts/main/CurveTwocryptoFactory.vy b/contracts/main/CurveTwocryptoFactory.vy
@@ -139,7 +139,9 @@ def deploy_pool(
     @return Address of the deployed pool
     """
     pool_implementation: address = self.pool_implementations[implementation_id]
+    _math_implementation: address = self.math_implementation
     assert pool_implementation != empty(address), "Pool implementation not set"
+    assert _math_implementation != empty(address), "Math implementation not set"
 
     assert mid_fee < MAX_FEE-1  # mid_fee can be zero
     assert out_fee >= mid_fee
@@ -183,7 +185,6 @@ def deploy_pool(
 
     # pool is an ERC20 implementation
     _salt: bytes32 = block.prevhash
-    _math_implementation: address = self.math_implementation
     pool: address = create_from_blueprint(
         pool_implementation,
         _name,