Fix beatGroups in 6/4, 9/4, 12/4 (take 2) #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscuthbert
reviewed
Sep 18, 2024
| tempBeatGroups.push([1, 2]); | ||
| } else if (beatValue <= 1) { | ||
| } else if (meterDenominator <= 1) { | ||
| tempBeatGroups.push([1, 1]); | ||
| } else { | ||
| // 4/4, 2/4, 3/4, standard stuff |
There was a problem hiding this comment.
in the next PR can this comment be moved? It's now incorrectly placed.
mscuthbert
reviewed
Sep 18, 2024
| tempBeatGroups.push([3, meterDenominator]); | ||
| } | ||
| } else { | ||
| tempBeatGroups.push([2, 8]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows after #260: compound meters should have a compound beat grouping.
This PR also renames some variables, mostly just to help me follow the logic for compound meters:
7/4 is an exception where I think [[2, 8]] makes sense.