Skip to content

Commit

Permalink
Merge pull request #59 from cwensley/build-output-updates
Browse files Browse the repository at this point in the history
Add suffix to each platform output so it is clear which to use
  • Loading branch information
cwensley authored Sep 17, 2022
2 parents e7fcb88 + a48d13c commit 6e0b561
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ jobs:
run: dotnet publish Source/PabloDraw/PabloDraw.csproj ${{ env.BuildParameters }} /bl:artifacts/log/pablodraw-linux.binlog

- name: Create gzip
run: tar -czvf pablodraw.tar.gz -C artifacts/publish/${{ env.BuildConfiguration }}/Linux .
run: tar -czvf pablodraw-linux-x64.tar.gz -C artifacts/publish/${{ env.BuildConfiguration }}/Linux .

- uses: actions/upload-artifact@v2
with:
name: pablodraw-linux-binaries-x64
path: pablodraw.tar.gz
path: pablodraw-linux-x64.tar.gz

- name: Upload log files
if: ${{ failure() }}
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: pablodraw-mac
path: artifacts/bin/PabloDraw/${{ env.BuildConfiguration }}/net6.0/PabloDraw.dmg
path: artifacts/publish/${{ env.BuildConfiguration }}/Mac/*.dmg

- name: Upload log files
if: ${{ failure() }}
Expand Down
20 changes: 18 additions & 2 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,18 @@
"clear": true
},
"problemMatcher": "$msCompile"
}
},
{
"label": "check-outdated-dependencies",
"type": "shell",
"command": "dotnet tool restore && dotnet outdated \"${workspaceFolder}/Source/Pablo Desktop.sln\" ${input:outdated}",
"problemMatcher": [],
"presentation": {
"clear": true,
"focus": true
}
}

],
"inputs": [
{
Expand All @@ -117,6 +128,11 @@
"command": "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere.exe\" -version \"[16,18)\" -latest -products * -requires Microsoft.Component.MSBuild -find MSBuild\\**\\Bin\\MSBuild.exe",
"useFirstResult": "true"
}
}
},
{
"type": "promptString",
"id": "outdated",
"description": "Options for dotnet outdated. --help to see options, -u -inc <MyPackage> to update a single package, or leave blank to check for updates."
}
]
}
4 changes: 2 additions & 2 deletions Source/Pablo/Pablo.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
<ProjectReference Include="$(EtoBasePath)src\Eto\Eto.csproj" Condition="$(EtoBasePath) != ''" />
<PackageReference Include="Eto.Forms" Version="2.7.1" Condition="$(EtoBasePath) == ''" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="sharpcompress" Version="0.30.1" />
<PackageReference Include="Mono.Nat" Version="3.0.2" />
<PackageReference Include="sharpcompress" Version="0.32.2" />
<PackageReference Include="Mono.Nat" Version="3.0.3" />
<PackageReference Include="Lidgren.Network" Version="1.0.2" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="6.0.0" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<ProductVersion>3.10</ProductVersion>
<ProjectGuid>38a42f6d-a417-45b0-8ec8-a700f31cbe26</ProjectGuid>
<SchemaVersion>2.0</SchemaVersion>
<OutputName>PabloDraw</OutputName>
<OutputName>PabloDraw-Windows-x64</OutputName>
<OutputType>Package</OutputType>
<WixTargetsPath Condition=" '$(WixTargetsPath)' == '' AND '$(MSBuildExtensionsPath32)' != '' ">$(MSBuildExtensionsPath32)\Microsoft\WiX\v3.x\Wix.targets</WixTargetsPath>
<WixTargetsPath Condition=" '$(WixTargetsPath)' == '' ">$(MSBuildExtensionsPath)\Microsoft\WiX\v3.x\Wix.targets</WixTargetsPath>
Expand Down
9 changes: 8 additions & 1 deletion Source/PabloDraw/PabloDraw.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@
<EnableDmgBuild>True</EnableDmgBuild>
<TrimMode>Link</TrimMode>
<PublishTrimmed>True</PublishTrimmed>
<DmgName>PabloDraw-Mac</DmgName>
<DmgVolumeName>PabloDraw</DmgVolumeName>
<DmgOutputPath>$(PublishDir)</DmgOutputPath> <!-- Eto will use this by default if specified in 2.7.2 -->
</PropertyGroup>

<PropertyGroup>
Expand Down Expand Up @@ -73,7 +76,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Mono.Nat" Version="3.0.2" />
<PackageReference Include="Mono.Nat" Version="3.0.3" />
<PackageReference Include="Lidgren.Network" Version="1.0.2" />
</ItemGroup>

Expand All @@ -100,5 +103,9 @@

<Import Project="$(EtoBasePath)\build\Common.Mac.targets" Condition="$(BuildTarget) == 'Mac' and $(EtoBasePath) != ''" />

<Target Name="_CreateDmgOutputPath" BeforeTargets="MacCreateDmg" Condition="$(DmgOutputPath) != ''">
<!-- Should go into Eto 2.7.2 -->
<MakeDir Directories="$(DmgOutputPath)" />
</Target>

</Project>
12 changes: 12 additions & 0 deletions dotnet-tools.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": 1,
"isRoot": true,
"tools": {
"dotnet-outdated-tool": {
"version": "4.1.0",
"commands": [
"dotnet-outdated"
]
}
}
}

0 comments on commit 6e0b561

Please sign in to comment.