fix: deadlock in encoder when replacing filter #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you split them up? |
|
sure, as separate commits or separate pull requests? |
- Added a new FIFO flag: `XXX_FIFO_PULL_POKE` - Added `sp_xxx_fifo_poke` to send a "poke" to a FIFO, forcing any pull operation with the `XXX_FIFO_PULL_POKE` flag to return with `EAGAIN` - Added `sp_xxx_fifo_peek_flags` - Added more logging
The encoder would be stuck pulling a frame when its input is disconnected, preventing it from ever linking with a new input.
Controls whether filters send EOS when destroyed.
Shows how one can hot-swap a filtergraph without killing the encoder.
nasso
force-pushed
the
fix-filter-swap-encoder-deadlock
branch
from
7edaa45
to
ed2ed2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace_node.cexample showing how one can hot-swap a filtergraphsend_eosinit option to control whether filters send EOS when destroyedXXX_FIFO_PULL_POKEsp_xxx_fifo_poketo send a "poke" to a FIFO, forcing any pull operation with theXXX_FIFO_PULL_POKEflag to return withEAGAINencode.cwhere the encoder would be stuck pulling a frame when its input is disconnected, preventing it from ever linking with a new input.sp_xxx_fifo_peek_flags