Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fix #194

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Build fix #194

merged 6 commits into from
Aug 17, 2023

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Aug 16, 2023 •
edited
Loading

NOTE: Failing checks on devel can be ignored.

Desired Outcome

Jenkins build fails while testing the Host Identity role against Conjur Enterprise with the following message:

Error response from daemon: Address already in use
Error: failed to start containers: ${cli_cid}

This is after Jenkins successfully runs the Variable Lookup plugin tests against Conjur Enterprise.

Implemented Changes

  • Destroy CLI container during cleanup
  • Add daily trigger to Jenkinsfile
  • Update Sanity and Unit test version matrix

Connected Issue/Story

CNJR-2444

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell force-pushed the build-fix branch 6 times, most recently from 834485d to ee57b97 Compare August 16, 2023 14:39
@john-odonnell john-odonnell marked this pull request as ready for review August 16, 2023 16:21
@john-odonnell john-odonnell requested a review from a team as a code owner August 16, 2023 16:21
@szh szh self-requested a review August 17, 2023 15:08
doodlesbykumbi
doodlesbykumbi approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! Appreciate the attention to detail e.g. cleaning up the unused imports

@john-odonnell john-odonnell merged commit b1937e1 into main Aug 17, 2023
38 of 40 checks passed
@john-odonnell john-odonnell deleted the build-fix branch August 17, 2023 16:04
@szh szh removed their request for review August 17, 2023 16:56
@gl-johnson gl-johnson mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlesbykumbi doodlesbykumbi doodlesbykumbi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-odonnell @doodlesbykumbi