Skip to content

Commit

Permalink
Add Laravel 7.x support (#12)
Browse files Browse the repository at this point in the history
Add Laravel 7.x support
  • Loading branch information
antonkomarev authored Mar 7, 2020
1 parent 0ce9393 commit 1741fd2
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 78 deletions.
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
/tests export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/.php_cs export-ignore
/.styleci.yml export-ignore
/.travis.yml export-ignore
/CODE_OF_CONDUCT.md export-ignore
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
vendor/
.php_cs.cache
.phpunit.result.cache
composer.lock
composer.phar
Expand Down
64 changes: 0 additions & 64 deletions .php_cs

This file was deleted.

10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to `cybercog/laravel-youtrack-sdk` will be documented in thi

## [Unreleased]

## [5.2.0] - 2020-03-07

### Added

- ([#12]) Laravel 7 support

## [5.1.0] - 2019-09-04

### Added
Expand Down Expand Up @@ -65,7 +71,8 @@ All notable changes to `cybercog/laravel-youtrack-sdk` will be documented in thi

- Initial release

[Unreleased]: https://github.com/cybercog/laravel-youtrack-sdk/compare/5.1.0...master
[Unreleased]: https://github.com/cybercog/laravel-youtrack-sdk/compare/5.2.0...master
[5.2.0]: https://github.com/cybercog/laravel-youtrack-sdk/compare/5.1.0...5.2.0
[5.1.0]: https://github.com/cybercog/laravel-youtrack-sdk/compare/5.0.0...5.1.0
[5.0.0]: https://github.com/cybercog/laravel-youtrack-sdk/compare/4.2.0...5.0.0
[4.2.0]: https://github.com/cybercog/laravel-youtrack-sdk/compare/4.1.0...4.2.0
Expand All @@ -74,4 +81,5 @@ All notable changes to `cybercog/laravel-youtrack-sdk` will be documented in thi
[3.0.0]: https://github.com/cybercog/laravel-youtrack-sdk/compare/2.0.0...3.0.0
[2.0.0]: https://github.com/cybercog/laravel-youtrack-sdk/compare/1.0.0...2.0.0

[#12]: https://github.com/cybercog/laravel-youtrack-sdk/pull/12
[#9]: https://github.com/cybercog/laravel-youtrack-sdk/pull/9
8 changes: 2 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,14 @@ Due to time constraints, we are not always able to respond as quickly as we woul

## Coding Guidelines

This project comes with a configuration file for php-cs-fixer (.php_cs) that you can use to (re)format your sourcecode for compliance with this project's coding guidelines:

```sh
$ vendor/bin/php-cs-fixer fix
```
This project follows [PSR-12 coding style guide](https://www.php-fig.org/psr/psr-12/).

## PHPUnit tests

The phpunit script can be used to invoke the PHPUnit test runner:

```sh
$ composer test
$ vendor/bin/phpunit
```

## Reporting issues
Expand Down
7 changes: 3 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,11 @@
"require": {
"php": "^7.1",
"cybercog/youtrack-php-sdk": "^4.0",
"illuminate/support": "5.8.*|^6.0"
"illuminate/support": "^5.8|^6.0|^7.0"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^2.10",
"orchestra/testbench": "3.8.*|^4.0",
"phpunit/phpunit": "^7.0|^8.0"
"orchestra/testbench": "^3.8|^4.0|^5.0",
"phpunit/phpunit": "^7.0|^8.0|^9.0"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion src/YouTrackServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private function resolveAuthorizerDriver(ConfigContract $config): AuthorizerCont
$authorizer = $config->get('youtrack.authorizer');

$options = $config->get('youtrack.authorizers.' . $authorizer);
if ($authorizer == 'cookie') {
if ($authorizer === 'cookie') {
return new $options['driver'](
new CookieAuthenticator($options['username'], $options['password'])
);
Expand Down

0 comments on commit 1741fd2

Please sign in to comment.