This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Migrate InternGroup to Group #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrist
reviewed
Dec 19, 2016
| @@ -0,0 +1 @@ | |||
| [{"model": "core.group", "pk": 1, "fields": {"name": "Hovedstyret", "leader": 1, "description": "HS sitt ansvar er \u00e5 drive foreningen"}}, {"model": "core.group", "pk": 2, "fields": {"name": "Kjellerstyret", "leader": 2, "description": "Kjellerstyret styrer Escape"}}, {"model": "core.group", "pk": 3, "fields": {"name": "\u00d8konomi", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 4, "fields": {"name": "Arrangementsgruppen", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 5, "fields": {"name": "Promotering", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 6, "fields": {"name": "Bar", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 7, "fields": {"name": "Kaf\u00e9", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 8, "fields": {"name": "DJ", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 9, "fields": {"name": "Arkivgruppen", "leader": 1, "description": ""}}, {"model": "core.group", "pk": 10, "fields": {"name": "Webgruppa", "leader": 1, "description": ""}}] | |||
There was a problem hiding this comment.
Kunne du pretty-formatert dette? Også mangler det en newline :p
henrist
reviewed
Dec 19, 2016
| description = models.CharField(max_length=300, null=True, blank=True) | ||
|
|
||
| def __str__(self): | ||
| return self.name |
Pretty printed group fixtures. Fixed some small code style stuff in core.models
|
Har testet med både ny database og å lage en database fra master branchen og å kjøre migrasjonene på dem. Begge deler funker fint. |
Ah, nice! :) |
henrist
reviewed
Dec 19, 2016
| "description": "" | ||
| } | ||
| } | ||
| ] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like I mentioned in #78. I think the InternGroup should have been in core and not in Intern since it's the same thing for vouchers.
I haven't done any changes in vouchers in here. Would like some feedback on it before doing it.