fix(footer): Adjust bottom margin based on scroll position to preserve safe area 2063 #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e safe area This commit fixes the issue of incorrect bottom margin for the footer breadcrumbs during scrolling. The Footer component now dynamically adjusts the bottom margin based on the user's scroll position. A new state variable isScrolledToBottom was introduced to track the scroll position, and a useEffect hook handles scroll events to update this state. The bottom margin is conditionally applied to ensure it's only present when needed
zahidhussain998
changed the title
raineorshine
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Hi, thanks for your contribution.
There are a couple issues with the proposed solution.
- The issues specifies "If the safe area is partially obscured, the bottom margin should adjust accordingly." That could be said more clearly, but basically it means that the bottom margin needs to be adjusted based on the distance from the bottom of the page. So
isScrolledToBottom: numbershould probably bedistanceFromScrollBottom: numberinstead. - The
.nav-bottom .nav-containeralready uses --safe-area-inset-bottom. The solution should develop an integrated solution applied to the same element, rather than a separate solution applied to the footer.
…sted the bottom margin dynamically. updated state management changed from isScrolledToBottom to distanceFromScrollBottom and adjusted the bottom margin dynamically.
raineorshine
force-pushed
the
main
branch
7 times, most recently
from
80019f7
to
10b9d7c
Compare
|
Checking in. A solution needs to be developed that takes into account the existing safe area logic. Are you still interested in this, or should I close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue of incorrect bottom margin for the footer breadcrumbs during scrolling (#2063). The Footer component now dynamically adjusts the bottom margin based on the user's scroll position. A new state variable isScrolledToBottom was introduced to track the scroll position, and a useEffect hook handles scroll events to update this state. The bottom margin is conditionally applied to ensure it's only present when needed