Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a 'Scroll up for tutorial' button after scrolling past the instructions #2288

Merged
merged 12 commits into from
Aug 23, 2024
Merged

feat: add a 'Scroll up for tutorial' button after scrolling past the instructions #2288

merged 12 commits into from
Aug 23, 2024

Commits on Aug 15, 2024

  1. feat: add a 'Scroll up for tutorial' button after scrolling past the … 

    …instructions
    @trevinhofmann
    trevinhofmann committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    331f22e View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. fix: ensure that the tutorial scroll-up button is visible when the iO… 

    …S keyboard is open by switching to position: absolute
    @trevinhofmann
    trevinhofmann committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4488532 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. refactor: use the existing scrollTo function

    @trevinhofmann
    trevinhofmann committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6019ce4 View commit details
    Browse the repository at this point in the history

  2. fix: change the useIsVisible hook to manually calculate visibility fr… 

    …om getBoundingClientRect
    @trevinhofmann
    trevinhofmann committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a345ed3 View commit details
    Browse the repository at this point in the history

  3. fix: forward the tutorial ref to the 'Next' button to determine displ… 

    …ay of the 'Scroll up' button
    @trevinhofmann
    trevinhofmann committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9d6e996 View commit details
    Browse the repository at this point in the history

  4. refactor: inline the TutorialScrollUpButton props

    @trevinhofmann
    trevinhofmann committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6c6563b View commit details
    Browse the repository at this point in the history

  5. feat: improved the responsiveness of the TutorialScrollUpButton when … 

    …scrolling by having the scrollPosition update without a transition
    @trevinhofmann
    trevinhofmann committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e57df46 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. refactor: use the scrollTopStore instead of a new useScrollPosition hook

    @trevinhofmann
    trevinhofmann committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5c38140 View commit details
    Browse the repository at this point in the history

  2. docs: add a note in the JSDoc about the ref object returned by useIsV… 

    …isible
    @trevinhofmann
    trevinhofmann committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3742708 View commit details
    Browse the repository at this point in the history

  3. docs: add JSDoc explaining the props (particularly, nextRef) of the T… 

    …utorialNavigation component
    @trevinhofmann
    trevinhofmann committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e2fbc16 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. comment

    @raineorshine
    raineorshine committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9eef751 View commit details
    Browse the repository at this point in the history

  2. refactor: use the useEffect hook provided by the scrollTopStore

    @trevinhofmann
    trevinhofmann committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    84ce5aa View commit details
    Browse the repository at this point in the history