Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort namespace in generated configmaps #54

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

zoetrope
Copy link
Member

Because the order of client-go's List is random, ConfigMap will be updated indefinitely.

@zoetrope zoetrope requested a review from a team June 28, 2024 04:47
Because the order of client-go's List is random, ConfigMap will be updated indefinitely.
@zoetrope zoetrope force-pushed the fix-namespaces-order branch from b099bdf to dd6e5d9 Compare June 28, 2024 04:50
@zoetrope zoetrope added the bug Something isn't working label Jun 28, 2024
Copy link
Contributor

@takahiro-yamada takahiro-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope merged commit 9e85ecf into main Jun 28, 2024
10 checks passed
@zoetrope zoetrope deleted the fix-namespaces-order branch June 28, 2024 06:35
zoetrope added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants