Implement import and cleanup #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
implement-import-and-cleanup
branch
5 times, most recently
from
e6ec22c to
cde9c4f
Compare
ushitora-anqou
commented
Nov 15, 2024
satoru-takeuchi
requested changes
Nov 18, 2024
satoru-takeuchi
requested changes
Nov 19, 2024
|
@ushitora-anqou I guess we can remove a code snippet for testing. |
satoru-takeuchi
requested changes
Nov 20, 2024
There was a problem hiding this comment.
@ushitora-anqou I have finished the review. Please reflect comments, thanks.
ushitora-anqou
force-pushed
the
implement-import-and-cleanup
branch
from
25b9590 to
afc7d1f
Compare
Fixed in 2371058 |
|
@satoru-takeuchi I've fixed your points. Could you review this again? |
satoru-takeuchi
approved these changes
Nov 20, 2024
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
We stopped setting SyncedToRemote=True in an ad hoc manner in the previous commit, so we can't use `resMgr.WaitForbackupSyncedToRemote` to wait for all necessary resources to be ready. This commit resolves the problem above by packing all the tests into `Eventually` in order to wait the resources to be ready. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
We need to give a StorageClass name as a command-line argument of
mantle-controller so that it can create PVCs to store its exported data.
To do so, we need to fix the StorageClass name (and the pool name used
as a parameter of the StorageClass) before starting mantle-controller.
However, the current e2e test generates the names of the StorageClass
and pool in runtime, after starting the controller.
This commit resolves the problem above, by avoiding generating the names
in runtime and fixing them as constants ("rook-ceph-block") instead.
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
implement-import-and-cleanup
branch
from
afc7d1f to
2da741f
Compare
|
@satoru-takeuchi I squashed my commits. Could you review this again? The code included in the commits shouldn't have been changed: https://github.com/cybozu-go/mantle/compare/afc7d1fa1bbb7c2f8300abdea63c4a8f7f2e5a87..2da741f78b859c867c7699fae40db6a477da95f7 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.