support http(s) proxy #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
add-proxy-support
branch
2 times, most recently
from
b968c03 to
b973288
Compare
satoru-takeuchi
requested changes
Dec 9, 2024
|
@satoru-takeuchi Could you review this PR again? |
satoru-takeuchi
approved these changes
Dec 10, 2024
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…ingPV Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
add-proxy-support
branch
from
49b0ba2 to
bbf286c
Compare
|
@satoru-takeuchi I've squashed my commits. Could you review this PR again? |
satoru-takeuchi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
-http-proxy,-https-proxy, and-no-proxycommand-line arguments to support http(s) proxies that should be used to access object storages and gRPC services from the primary Mantle controller.