use trash to remove RBD images asynchronously #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes: - RBDInfo struct is renamed to RBDImageInfo. - RBDImageInfo's Parent field becomes optional. - RBDImageInfo come to have an ID field. Note that the callers of this function should check that the Parent field of the result is not nil if they want to use it, because it's now optional and a nillable pointer. Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
We should remove RBD images asynchronously to finish each reconiliation iteration quickly. This commit supports asynchronous removal of the RBD images by the following two steps: 1. Run `rbd trash mv` to move the RBD image to trash. 2. Run `ceph rbd task add trash remove` to add a task to remove an image from trash. cf. https://github.com/ceph/ceph-csi/blob/d8a040719e0ad491ad144fe361b67e6bd2109710/docs/design/proposals/rbd-snap-clone.md#rbd-cli-commands-to-delete-a-snapshot Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
use-trash-mv
branch
from
a2cea72 to
10cec2b
Compare
satoru-takeuchi
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should remove RBD images asynchronously to finish each reconiliation
iteration quickly. This commit supports asynchronous removal of the RBD
images by the following two steps:
rbd trash mvto move the RBD image to trash.ceph rbd task add trash removeto add a task to remove an imagefrom trash.
cf. https://github.com/ceph/ceph-csi/blob/d8a040719e0ad491ad144fe361b67e6bd2109710/docs/design/proposals/rbd-snap-clone.md#rbd-cli-commands-to-delete-a-snapshot