enhance tests (part2) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
enhance-tests-part2
branch
from
2c47e47 to
670199b
Compare
…createPVC Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…eateMantleBackup Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…mary role change Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…econdary role change Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
enhance-tests-part2
branch
from
670199b to
9102209
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
enhance-tests-part2
branch
2 times, most recently
from
0173ae9 to
d5caa00
Compare
…sting Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
enhance-tests-part2
branch
from
d5caa00 to
3c479d6
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
enhance-tests-part2
branch
from
3c479d6 to
8d0dc2a
Compare
ushitora-anqou
requested review from
satoru-takeuchi
and removed request for
satoru-takeuchi
satoru-takeuchi
requested changes
Jan 14, 2025
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…orarily Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…FTER for flexibility Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
enhance-tests-part2
branch
from
de143df to
e138da3
Compare
|
@satoru-takeuchi I've fixed your points, so could you review this PR again? |
|
Note that we don't need to squash the new commits, because they're not fixups. |
satoru-takeuchi
approved these changes
Jan 14, 2025
|
Oops. there is not commits to squash. I'll merge it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be rebased after #81 is merged.done.