update runner version to 2.313.0 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokaze
force-pushed
the
update-runner-version
branch
from
c4779c7 to
2e2faa5
Compare
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
yokaze
force-pushed
the
update-runner-version
branch
from
2e2faa5 to
37fe960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
RUNNER_VERSIONto 2.313.0 and changes some test content.The modified tests originally checked
DeletionTimeto be nil, it is indeed true immediate after the job fails.However, the controller eventually finds the pods being in failed state, and updates the field with a non-nil value.
Therefore testing the field against nil is flaky: it is better to use
Eventuallyand check it being non-nil.Signed-off-by: Daichi Sakaue daichi-sakaue@cybozu.co.jp