fix PDB maxUnavailable equal to 0 when executing backup jobs

cybozu-go · Nov 30, 2023 · 4479fcc · 4479fcc
1 parent 9798c7f
commit 4479fcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/controllers/mysqlcluster_controller.go b/controllers/mysqlcluster_controller.go
@@ -955,7 +955,7 @@ func (r *MySQLClusterReconciler) reconcileV1PDB(ctx context.Context, req ctrl.Re
 
 	var maxUnavailable intstr.IntOrString
 	if backupCronJobIsRnning {
-		maxUnavailable = intstr.FromInt(int(cluster.Spec.Replicas))
+		maxUnavailable = intstr.FromInt(0)
 	} else {
 		maxUnavailable = intstr.FromInt(int(cluster.Spec.Replicas / 2))
 	}

diff --git a/controllers/mysqlcluster_controller_test.go b/controllers/mysqlcluster_controller_test.go
@@ -1545,7 +1545,7 @@ var _ = Describe("MySQLCluster reconciler", func() {
 			if err != nil {
 				return err
 			}
-			if pdb.Spec.MaxUnavailable.IntVal != cluster.Spec.Replicas {
+			if pdb.Spec.MaxUnavailable.IntVal != 0 {
 				return fmt.Errorf("PodDisruptionBudget MaxUnavailable is no equal Replica Count.")
 			}
 			return nil