Add a line break to kubectl-moco start/stop command's message (#737)

Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
cybozu-go · Sep 6, 2024 · 4c3ec5d · 4c3ec5d
1 parent 3bb8fdb
commit 4c3ec5d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/cmd/kubectl-moco/cmd/start.go b/cmd/kubectl-moco/cmd/start.go
@@ -3,7 +3,6 @@ package cmd
 import (
 	"context"
 	"fmt"
-	"os"
 
 	mocov1beta2 "github.com/cybozu-go/moco/api/v1beta2"
 	"github.com/cybozu-go/moco/pkg/constants"
@@ -50,16 +49,15 @@ func startClustering(ctx context.Context, name string) error {
 	}
 
 	if equality.Semantic.DeepEqual(orig, cluster) {
-		fmt.Fprintf(os.Stdout, "The clustering is already running.")
+		fmt.Println("The clustering is already running.")
 		return nil
 	}
 
 	if err := kubeClient.Update(ctx, cluster); err != nil {
 		return fmt.Errorf("failed to start clustering of MySQLCluster: %w", err)
 	}
 
-	fmt.Fprintf(os.Stdout, "started clustering of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
-
+	fmt.Printf("started clustering of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
 	return nil
 }
 
@@ -89,15 +87,14 @@ func startReconciliation(ctx context.Context, name string) error {
 	}
 
 	if equality.Semantic.DeepEqual(orig, cluster) {
-		fmt.Fprintf(os.Stdout, "The reconciliation is already running.")
+		fmt.Println("The reconciliation is already running.")
 		return nil
 	}
 
 	if err := kubeClient.Update(ctx, cluster); err != nil {
 		return fmt.Errorf("failed to start reconciliation of MySQLCluster: %w", err)
 	}
 
-	fmt.Fprintf(os.Stdout, "started reconciliation of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
-
+	fmt.Printf("started reconciliation of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
 	return nil
 }
diff --git a/cmd/kubectl-moco/cmd/stop.go b/cmd/kubectl-moco/cmd/stop.go
@@ -3,7 +3,6 @@ package cmd
 import (
 	"context"
 	"fmt"
-	"os"
 
 	mocov1beta2 "github.com/cybozu-go/moco/api/v1beta2"
 	"github.com/cybozu-go/moco/pkg/constants"
@@ -51,16 +50,15 @@ func stopClustering(ctx context.Context, name string) error {
 	cluster.Annotations[constants.AnnClusteringStopped] = "true"
 
 	if equality.Semantic.DeepEqual(orig, cluster) {
-		fmt.Fprintf(os.Stdout, "The clustering is already stopped.")
+		fmt.Println("The clustering is already stopped.")
 		return nil
 	}
 
 	if err := kubeClient.Update(ctx, cluster); err != nil {
 		return fmt.Errorf("failed to stop clustering of MySQLCluster: %w", err)
 	}
 
-	fmt.Fprintf(os.Stdout, "stopped clustering of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
-
+	fmt.Printf("stopped clustering of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
 	return nil
 }
 
@@ -91,15 +89,14 @@ func stopReconciliation(ctx context.Context, name string) error {
 	cluster.Annotations[constants.AnnReconciliationStopped] = "true"
 
 	if equality.Semantic.DeepEqual(orig, cluster) {
-		fmt.Fprintf(os.Stdout, "The reconciliation is already stopped.")
+		fmt.Println("The reconciliation is already stopped.")
 		return nil
 	}
 
 	if err := kubeClient.Update(ctx, cluster); err != nil {
 		return fmt.Errorf("failed to stop reconciliation of MySQLCluster: %w", err)
 	}
 
-	fmt.Fprintf(os.Stdout, "stopped reconciliation of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
-
+	fmt.Printf("stopped reconciliation of MySQLCluster %q\n", fmt.Sprintf("%s/%s", namespace, name))
 	return nil
 }