Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add deprecatedversion marker #592

Merged
merged 1 commit into from
Oct 25, 2023
Merged

api: add deprecatedversion marker #592

merged 1 commit into from
Oct 25, 2023

Conversation

shunki-fujita
Copy link
Contributor

add deprecatedversion marker.
Part of #545

@shunki-fujita shunki-fujita marked this pull request as ready for review October 25, 2023 04:01
ymmt2005
ymmt2005 reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question.
I know the warning is optional, but what happens if we don't give it?

@shunki-fujita
Copy link
Contributor Author

@ymmt2005

Question. I know the warning is optional, but what happens if we don't give it?

Probably use the following format:
https://github.com/kubernetes/kubernetes/blob/558a6797a2962dd77c38345549d2a2452bbc3cdc/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go#L1037

@ymmt2005
Copy link
Member

Thanks.

ymmt2005
ymmt2005 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit 54db676 into cybozu-go:main Oct 25, 2023
15 checks passed
@kmdkuk kmdkuk mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunki-fujita @ymmt2005